The following document contains the results of PMD 4.2.2.
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 127 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 136 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 146 |
| Avoid throwing null pointer exceptions. | 150 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 162 |
| Avoid throwing null pointer exceptions. | 166 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 177 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 59 |
| Avoid throwing raw exception types. | 61 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 101 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 119 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 158 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 236 |
| Violation | Line |
|---|---|
| The String literal "Configuration is frozen" appears 4 times in this file; the first occurrence is on line 86 | 86 |
| Violation | Line |
|---|---|
| The String literal "Configuration is frozen" appears 4 times in this file; the first occurrence is on line 133 | 133 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 54 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 51 |
| Avoid modifiers which are implied by the context | 53 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 59 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 63 |
| Avoid modifiers which are implied by the context | 65 |
| Violation | Line |
|---|---|
| Avoid throwing null pointer exceptions. | 81 |
| Avoid catching NullPointerException; consider removing the cause of the NPE. | 96 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'HashMap'; use the interface instead | 59 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 64 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 66 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 68 |
| The String literal "Configuration is frozen" appears 5 times in this file; the first occurrence is on line 96 | 96 |
| Avoid using if statements without curly braces | 119 - 120 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'contextPath'. | 104 |
| These nested if statements could be combined | 122 - 137 |
| Violation | Line |
|---|---|
| The field name indicates a constant but its modifiers do not | 49 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 91 |
| Avoid using if statements without curly braces | 92 - 93 |
| Avoid throwing raw exception types. | 93 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 58 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 47 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 56 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 17 |
| Avoid modifiers which are implied by the context | 24 |
| Avoid modifiers which are implied by the context | 30 |
| Avoid modifiers which are implied by the context | 37 |
| Avoid modifiers which are implied by the context | 42 |
| Avoid modifiers which are implied by the context | 47 |
| Avoid modifiers which are implied by the context | 53 |
| Violation | Line |
|---|---|
| Avoid printStackTrace(); use a logger call instead. | 73 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 69 - 70 |
| Avoid using if statements without curly braces | 75 - 76 |
| Violation | Line |
|---|---|
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 32 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 50 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 69 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 70 |
| Avoid printStackTrace(); use a logger call instead. | 129 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 136 |
| Avoid using if statements without curly braces | 157 - 158 |
| Avoid using if statements without curly braces | 165 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 74 |
| Violation | Line |
|---|---|
| Avoid throwing raw exception types. | 83 |
| Avoid throwing raw exception types. | 86 |
| Avoid throwing raw exception types. | 89 |
| Violation | Line |
|---|---|
| Overriding method merely calls super | 64 - 66 |
| Avoid throwing raw exception types. | 80 |
| The String literal "Not implemented" appears 23 times in this file; the first occurrence is on line 80 | 80 |
| Avoid printStackTrace(); use a logger call instead. | 81 |
| Avoid throwing raw exception types. | 89 |
| Avoid printStackTrace(); use a logger call instead. | 90 |
| Avoid throwing raw exception types. | 98 |
| Avoid printStackTrace(); use a logger call instead. | 99 |
| Avoid throwing raw exception types. | 107 |
| Avoid printStackTrace(); use a logger call instead. | 108 |
| Avoid throwing raw exception types. | 116 |
| Avoid printStackTrace(); use a logger call instead. | 117 |
| Avoid throwing raw exception types. | 125 |
| Avoid printStackTrace(); use a logger call instead. | 126 |
| Avoid throwing raw exception types. | 134 |
| Avoid printStackTrace(); use a logger call instead. | 135 |
| Avoid throwing raw exception types. | 143 |
| Avoid printStackTrace(); use a logger call instead. | 144 |
| Avoid throwing raw exception types. | 152 |
| Avoid printStackTrace(); use a logger call instead. | 153 |
| Avoid throwing raw exception types. | 161 |
| Avoid printStackTrace(); use a logger call instead. | 162 |
| Avoid throwing raw exception types. | 170 |
| Avoid printStackTrace(); use a logger call instead. | 171 |
| Avoid throwing raw exception types. | 179 |
| Avoid printStackTrace(); use a logger call instead. | 180 |
| Avoid throwing raw exception types. | 188 |
| Avoid printStackTrace(); use a logger call instead. | 189 |
| Avoid throwing raw exception types. | 197 |
| Avoid printStackTrace(); use a logger call instead. | 198 |
| Avoid throwing raw exception types. | 206 |
| Avoid printStackTrace(); use a logger call instead. | 207 |
| Avoid throwing raw exception types. | 215 |
| Avoid printStackTrace(); use a logger call instead. | 216 |
| Avoid throwing raw exception types. | 224 |
| Avoid printStackTrace(); use a logger call instead. | 225 |
| Avoid throwing raw exception types. | 233 |
| Avoid printStackTrace(); use a logger call instead. | 234 |
| Avoid throwing raw exception types. | 242 |
| Avoid printStackTrace(); use a logger call instead. | 243 |
| Avoid throwing raw exception types. | 251 |
| Avoid printStackTrace(); use a logger call instead. | 252 |
| Avoid throwing raw exception types. | 260 |
| Avoid printStackTrace(); use a logger call instead. | 261 |
| Avoid throwing raw exception types. | 269 |
| Avoid printStackTrace(); use a logger call instead. | 270 |
| Avoid throwing raw exception types. | 278 |
| Avoid printStackTrace(); use a logger call instead. | 279 |
| Violation | Line |
|---|---|
| Consider replacing this Hashtable with the newer java.util.Map | 61 |
| Avoid throwing raw exception types. | 144 |
| The String literal "Not implemented" appears 8 times in this file; the first occurrence is on line 144 | 144 |
| Avoid printStackTrace(); use a logger call instead. | 145 |
| Avoid throwing raw exception types. | 154 |
| Avoid printStackTrace(); use a logger call instead. | 155 |
| Avoid throwing raw exception types. | 164 |
| Avoid printStackTrace(); use a logger call instead. | 165 |
| Avoid throwing raw exception types. | 182 |
| Avoid printStackTrace(); use a logger call instead. | 183 |
| Avoid throwing raw exception types. | 192 |
| Avoid printStackTrace(); use a logger call instead. | 193 |
| Avoid throwing raw exception types. | 203 |
| Avoid printStackTrace(); use a logger call instead. | 204 |
| Avoid throwing raw exception types. | 212 |
| Avoid printStackTrace(); use a logger call instead. | 213 |
| Avoid throwing raw exception types. | 222 |
| Avoid printStackTrace(); use a logger call instead. | 223 |
| Violation | Line |
|---|---|
| Consider replacing this Hashtable with the newer java.util.Map | 83 |
| Avoid throwing raw exception types. | 127 |
| The String literal "Not implemented" appears 22 times in this file; the first occurrence is on line 127 | 127 |
| Avoid throwing raw exception types. | 128 |
| The String literal "can't access SESSION_SCOPE without an HttpSession" appears 4 times in this file; the first occurrence is on line 164 | 164 |
| These nested if statements could be combined | 274 - 276 |
| Avoid throwing raw exception types. | 373 |
| Avoid throwing raw exception types. | 374 |
| Avoid throwing raw exception types. | 382 |
| Avoid throwing raw exception types. | 383 |
| Avoid throwing raw exception types. | 391 |
| Avoid throwing raw exception types. | 392 |
| Avoid throwing raw exception types. | 464 |
| Avoid throwing raw exception types. | 465 |
| Avoid throwing raw exception types. | 474 |
| Avoid throwing raw exception types. | 475 |
| Avoid throwing raw exception types. | 483 |
| Avoid throwing raw exception types. | 484 |
| Avoid throwing raw exception types. | 492 |
| Avoid throwing raw exception types. | 493 |
| Avoid throwing raw exception types. | 501 |
| Avoid throwing raw exception types. | 502 |
| Avoid throwing raw exception types. | 510 |
| Avoid throwing raw exception types. | 511 |
| Avoid throwing raw exception types. | 519 |
| Avoid throwing raw exception types. | 520 |
| Violation | Line |
|---|---|
| Consider replacing this Hashtable with the newer java.util.Map | 61 |
| Avoid throwing raw exception types. | 109 |
| The String literal "Not implemented" appears 20 times in this file; the first occurrence is on line 109 | 109 |
| Avoid printStackTrace(); use a logger call instead. | 110 |
| Avoid throwing raw exception types. | 119 |
| Avoid printStackTrace(); use a logger call instead. | 120 |
| Avoid throwing raw exception types. | 129 |
| Avoid printStackTrace(); use a logger call instead. | 130 |
| Avoid throwing raw exception types. | 140 |
| Avoid printStackTrace(); use a logger call instead. | 141 |
| Avoid throwing raw exception types. | 151 |
| Avoid printStackTrace(); use a logger call instead. | 152 |
| Avoid throwing raw exception types. | 163 |
| Avoid printStackTrace(); use a logger call instead. | 164 |
| Avoid throwing raw exception types. | 174 |
| Avoid printStackTrace(); use a logger call instead. | 175 |
| Avoid throwing raw exception types. | 185 |
| Avoid printStackTrace(); use a logger call instead. | 186 |
| Avoid throwing raw exception types. | 196 |
| Avoid printStackTrace(); use a logger call instead. | 197 |
| Avoid throwing raw exception types. | 208 |
| Avoid printStackTrace(); use a logger call instead. | 209 |
| Avoid throwing raw exception types. | 218 |
| Avoid printStackTrace(); use a logger call instead. | 219 |
| Avoid throwing raw exception types. | 228 |
| Avoid printStackTrace(); use a logger call instead. | 229 |
| Avoid throwing raw exception types. | 238 |
| Avoid printStackTrace(); use a logger call instead. | 239 |
| Avoid throwing raw exception types. | 249 |
| Avoid printStackTrace(); use a logger call instead. | 250 |
| Avoid throwing raw exception types. | 260 |
| Avoid printStackTrace(); use a logger call instead. | 261 |
| Avoid throwing raw exception types. | 271 |
| Avoid printStackTrace(); use a logger call instead. | 272 |
| Avoid throwing raw exception types. | 281 |
| Avoid printStackTrace(); use a logger call instead. | 282 |
| Avoid throwing raw exception types. | 292 |
| Avoid printStackTrace(); use a logger call instead. | 293 |
| Avoid throwing raw exception types. | 302 |
| Avoid printStackTrace(); use a logger call instead. | 303 |
| Avoid throwing raw exception types. | 312 |
| Avoid printStackTrace(); use a logger call instead. | 313 |
| Violation | Line |
|---|---|
| Consider replacing this Hashtable with the newer java.util.Map | 71 |
| Consider replacing this Hashtable with the newer java.util.Map | 76 |
| Avoid throwing raw exception types. | 146 |
| The String literal "Not implemented" appears 20 times in this file; the first occurrence is on line 146 | 146 |
| Avoid printStackTrace(); use a logger call instead. | 147 |
| Avoid throwing raw exception types. | 157 |
| Avoid printStackTrace(); use a logger call instead. | 158 |
| Avoid throwing raw exception types. | 167 |
| Avoid printStackTrace(); use a logger call instead. | 168 |
| Avoid throwing raw exception types. | 177 |
| Avoid printStackTrace(); use a logger call instead. | 178 |
| Avoid throwing raw exception types. | 188 |
| Avoid printStackTrace(); use a logger call instead. | 189 |
| Avoid throwing raw exception types. | 240 |
| Avoid printStackTrace(); use a logger call instead. | 241 |
| Avoid throwing raw exception types. | 250 |
| Avoid printStackTrace(); use a logger call instead. | 251 |
| Avoid throwing raw exception types. | 260 |
| Avoid printStackTrace(); use a logger call instead. | 261 |
| Avoid throwing raw exception types. | 270 |
| Avoid printStackTrace(); use a logger call instead. | 271 |
| Avoid throwing raw exception types. | 281 |
| Avoid printStackTrace(); use a logger call instead. | 282 |
| Avoid throwing raw exception types. | 291 |
| Avoid printStackTrace(); use a logger call instead. | 292 |
| Avoid throwing raw exception types. | 301 |
| Avoid printStackTrace(); use a logger call instead. | 302 |
| Avoid throwing raw exception types. | 331 |
| Avoid printStackTrace(); use a logger call instead. | 332 |
| Avoid throwing raw exception types. | 341 |
| Avoid printStackTrace(); use a logger call instead. | 342 |
| Avoid throwing raw exception types. | 352 |
| Avoid printStackTrace(); use a logger call instead. | 353 |
| Avoid throwing raw exception types. | 363 |
| Avoid printStackTrace(); use a logger call instead. | 364 |
| Avoid throwing raw exception types. | 373 |
| Avoid printStackTrace(); use a logger call instead. | 374 |
| Avoid throwing raw exception types. | 383 |
| Avoid printStackTrace(); use a logger call instead. | 384 |
| Avoid throwing raw exception types. | 393 |
| Avoid printStackTrace(); use a logger call instead. | 394 |
| Avoid throwing raw exception types. | 403 |
| Avoid printStackTrace(); use a logger call instead. | 404 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 44 |
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 50 |
| Violation | Line |
|---|---|
| Avoid throwing null pointer exceptions. | 86 |
| Avoid throwing null pointer exceptions. | 91 |
| Avoid throwing null pointer exceptions. | 97 |
| Avoid throwing null pointer exceptions. | 136 |
| Avoid using if...else statements without curly braces | 151 |
| Avoid using if...else statements without curly braces | 154 |
| Avoid using if...else statements without curly braces | 156 |
| Avoid empty if statements | 162 - 164 |
| Avoid printStackTrace(); use a logger call instead. | 177 |
| Avoid using if statements without curly braces | 187 - 188 |
| Avoid printStackTrace(); use a logger call instead. | 276 |
| Avoid empty if statements | 293 - 295 |
| Avoid printStackTrace(); use a logger call instead. | 297 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 18 - 19 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 114 - 115 |
| Avoid throwing null pointer exceptions. | 134 |
| Avoid using if statements without curly braces | 185 - 186 |
| Avoid using if statements without curly braces | 220 - 221 |
| Violation | Line |
|---|---|
| Avoid throwing null pointer exceptions. | 86 |
| Avoid throwing null pointer exceptions. | 103 |
| Consider simply returning the value vs storing it in local variable 'model' | 117 |
| Avoid throwing null pointer exceptions. | 133 |
| Avoid throwing null pointer exceptions. | 138 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 25 - 26 |
| Avoid using if statements without curly braces | 44 - 45 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 33 - 34 |
| Avoid printStackTrace(); use a logger call instead. | 44 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 21 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 74 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 102 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 53 |
| A method/constructor shouldn't explicitly throw java.lang.Exception | 53 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 13 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 89 - 90 |
| Avoid using if statements without curly braces | 108 - 109 |
| Avoid using if statements without curly braces | 110 - 111 |
| Avoid using if statements without curly braces | 112 - 113 |
| Violation | Line |
|---|---|
| Use ArrayList instead of Vector | 61 |
| Avoid throwing raw exception types. | 108 |
| Avoid throwing raw exception types. | 111 |
| Avoid throwing raw exception types. | 114 |
| Violation | Line |
|---|---|
| String.indexOf(char) is faster than String.indexOf(String). | 61 |
| Violation | Line |
|---|---|
| Avoid using if...else statements without curly braces | 116 |
| Avoid using if...else statements without curly braces | 118 |
| Violation | Line |
|---|---|
| Avoid printStackTrace(); use a logger call instead. | 124 |
| Use the correct logging statement for logging exceptions | 125 |
| Avoid printStackTrace(); use a logger call instead. | 149 |
| Avoid printStackTrace(); use a logger call instead. | 151 |
| Avoid printStackTrace(); use a logger call instead. | 153 |
| Avoid printStackTrace(); use a logger call instead. | 155 |
| Avoid printStackTrace(); use a logger call instead. | 175 |
| Avoid printStackTrace(); use a logger call instead. | 177 |
| Avoid printStackTrace(); use a logger call instead. | 179 |
| Avoid printStackTrace(); use a logger call instead. | 181 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 72 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 82 |
| Overriding method merely calls super | 85 - 87 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 104 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 68 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 171 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 185 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 364 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 364 |
| The user-supplied array 'preselect' is stored directly. | 386 |
| The user-supplied array 'preselect' is stored directly. | 386 |
| Avoid using if statements without curly braces | 408 - 409 |
| Avoid printStackTrace(); use a logger call instead. | 427 |
| Avoid using if statements without curly braces | 433 - 434 |
| Avoid printStackTrace(); use a logger call instead. | 452 |
| Avoid using if statements without curly braces | 459 - 460 |
| Violation | Line |
|---|---|
| The field name indicates a constant but its modifiers do not | 60 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 53 |
| Overriding method merely calls super | 60 - 62 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 52 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 55 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 54 - 55 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 29 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 55 |
| Avoid unused local variables such as 'dataMap'. | 57 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 53 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 72 |
| Avoid modifiers which are implied by the context | 76 |
| Avoid modifiers which are implied by the context | 85 |
| Avoid modifiers which are implied by the context | 94 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 54 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 50 |
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 61 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 73 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid modifiers which are implied by the context | 86 |
| Avoid modifiers which are implied by the context | 92 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 56 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 216 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 227 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 60 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'ArrayList'; use the interface instead | 54 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'HashMap'; use the interface instead | 53 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 76 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 80 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 85 |
| Avoid catching NullPointerException; consider removing the cause of the NPE. | 144 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'HashMap'; use the interface instead | 6 |
| Avoid modifiers which are implied by the context | 6 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 42 - 43 |
| Avoid using if statements without curly braces | 44 - 45 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 37 |
| Avoid modifiers which are implied by the context | 42 |
| Avoid modifiers which are implied by the context | 48 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 59 |
| Avoid throwing null pointer exceptions. | 69 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 117 |
| Avoid catching NullPointerException; consider removing the cause of the NPE. | 145 |
| Violation | Line |
|---|---|
| The field name indicates a constant but its modifiers do not | 80 |
| Avoid using if statements without curly braces | 105 - 106 |
| Avoid using if statements without curly braces | 107 - 108 |
| Consider simply returning the value vs storing it in local variable 'file' | 140 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 148 |
| Avoid using if statements without curly braces | 226 |
| System.out.print is used | 328 |
| Use the correct logging statement for logging exceptions | 329 |
| Avoid printStackTrace(); use a logger call instead. | 330 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 68 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 17 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 21 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 27 |
| Violation | Line |
|---|---|
| Overriding method merely calls super | 70 - 72 |
| Violation | Line |
|---|---|
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 53 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 54 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 55 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 111 |
| The method release() has an NCSS line count of 74 | 114 - 197 |
| Overriding method merely calls super | 220 - 222 |
| Avoid using if statements without curly braces | 650 - 651 |
| Avoid using if statements without curly braces | 661 - 662 |
| Avoid using if statements without curly braces | 663 - 664 |
| Avoid using if statements without curly braces | 665 - 666 |
| Avoid using if statements without curly braces | 667 - 668 |
| Avoid using if statements without curly braces | 669 - 670 |
| Use asList instead of tight loops | 713 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 59 |
| Avoid using if statements without curly braces | 81 - 82 |
| Avoid printStackTrace(); use a logger call instead. | 102 |
| Violation | Line |
|---|---|
| Overriding method merely calls super | 58 - 60 |
| Overriding method merely calls super | 68 - 70 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 65 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 47 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 57 |
| Avoid modifiers which are implied by the context | 62 |
| Avoid modifiers which are implied by the context | 68 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 78 |
| Avoid modifiers which are implied by the context | 87 |
| Avoid modifiers which are implied by the context | 89 |
| Avoid modifiers which are implied by the context | 98 |
| Avoid modifiers which are implied by the context | 100 |
| Avoid modifiers which are implied by the context | 109 |
| Avoid modifiers which are implied by the context | 111 |
| Avoid modifiers which are implied by the context | 120 |
| Avoid modifiers which are implied by the context | 122 |
| Avoid modifiers which are implied by the context | 131 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 68 - 69 |
| Avoid using if statements without curly braces | 70 - 71 |
| Avoid using if statements without curly braces | 81 - 82 |
| Avoid using if statements without curly braces | 184 - 185 |
| Avoid using if statements without curly braces | 186 - 187 |
| Violation | Line |
|---|---|
| Overridable method 'clone' called during object construction | 160 |
| Avoid printStackTrace(); use a logger call instead. | 162 |
| Avoid using if...else statements without curly braces | 203 |
| Avoid using if...else statements without curly braces | 205 |
| Violation | Line |
|---|---|
| Overridable method 'initializeInstantAccess' called during object construction | 161 |
| Avoid using if statements without curly braces | 198 - 199 |
| Avoid using if statements without curly braces | 200 - 201 |
| Avoid unused local variables such as 'test'. | 246 |
| Consider simply returning the value vs storing it in local variable 'result' | 415 |
| Consider simply returning the value vs storing it in local variable 'result' | 446 |
| The String literal "Cannot mix percent and non-percent column in one grid." appears 4 times in this file; the first occurrence is on line 473 | 473 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 503 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 504 |
| The String literal "data" appears 6 times in this file; the first occurrence is on line 511 | 511 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 534 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 535 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 587 |
| Avoid using if...else statements without curly braces | 600 |
| Avoid using if...else statements without curly braces | 602 |
| Avoid using if...else statements without curly braces | 605 |
| Avoid using if...else statements without curly braces | 607 |
| Avoid using if...else statements without curly braces | 618 |
| Avoid using if statements without curly braces | 625 - 626 |
| The String literal "rowId" appears 4 times in this file; the first occurrence is on line 660 | 660 |
| Avoid using if...else statements without curly braces | 830 |
| Avoid using if...else statements without curly braces | 832 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 895 |
| Avoid throwing raw exception types. | 902 |
| Avoid using if statements without curly braces | 919 - 920 |
| Avoid using if statements without curly braces | 939 - 940 |
| Avoid using if statements without curly braces | 1086 |
| Avoid using if statements without curly braces | 1092 |
| Violation | Line |
|---|---|
| Avoid using if...else statements without curly braces | 105 |
| Avoid using if...else statements without curly braces | 107 |
| Avoid using if...else statements without curly braces | 143 |
| Avoid using if...else statements without curly braces | 145 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 90 - 91 |
| Avoid using if statements without curly braces | 132 - 133 |
| Avoid using if statements without curly braces | 179 - 180 |
| Avoid using if statements without curly braces | 186 - 187 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 60 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid modifiers which are implied by the context | 86 |
| Avoid modifiers which are implied by the context | 94 |
| Avoid modifiers which are implied by the context | 100 |
| Avoid modifiers which are implied by the context | 107 |
| Avoid modifiers which are implied by the context | 113 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 56 |
| Avoid throwing null pointer exceptions. | 66 |
| Use the correct logging statement for logging exceptions | 84 |
| Avoid printStackTrace(); use a logger call instead. | 85 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 41 |
| Avoid modifiers which are implied by the context | 43 |
| Avoid modifiers which are implied by the context | 45 |
| Avoid modifiers which are implied by the context | 47 |
| Violation | Line |
|---|---|
| Avoid catching NullPointerException; consider removing the cause of the NPE. | 59 |
| Violation | Line |
|---|---|
| The method compareTo() has an NCSS line count of 66 | 97 - 225 |
| Violation | Line |
|---|---|
| Avoid throwing raw exception types. | 182 |
| Avoid throwing raw exception types. | 185 |
| Avoid throwing raw exception types. | 188 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 52 |
| Violation | Line |
|---|---|
| Avoid throwing null pointer exceptions. | 107 |
| Avoid throwing null pointer exceptions. | 115 |
| Violation | Line |
|---|---|
| Avoid using if...else statements without curly braces | 113 |
| Avoid using if...else statements without curly braces | 130 |
| Avoid using if...else statements without curly braces | 140 |
| Avoid using if statements without curly braces | 167 - 168 |
| Avoid using if statements without curly braces | 178 - 179 |
| Avoid using if statements without curly braces | 184 - 185 |
| Avoid using if statements without curly braces | 223 |
| String.indexOf(char) is faster than String.indexOf(String). | 223 |
| Avoid using if statements without curly braces | 238 - 239 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 67 - 68 |
| Avoid using if statements without curly braces | 125 - 126 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 201 - 202 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 57 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 54 |
| Overriding method merely calls super | 57 - 59 |
| Avoid using if statements without curly braces | 62 - 63 |
| Overriding method merely calls super | 83 - 85 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 53 |
| Overriding method merely calls super | 56 - 58 |
| Avoid using if statements without curly braces | 64 - 65 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 59 |
| Avoid using if statements without curly braces | 68 - 69 |
| Violation | Line |
|---|---|
| The field name indicates a constant but its modifiers do not | 49 |
| The field name indicates a constant but its modifiers do not | 50 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 82 |
| Caught exception is rethrown, original stack trace may be lost | 102 |
| Avoid using if statements without curly braces | 130 - 131 |
| Avoid using if statements without curly braces | 133 - 141 |
| These nested if statements could be combined | 144 - 146 |
| Avoid using if statements without curly braces | 149 - 150 |
| Avoid using if statements without curly braces | 188 - 189 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 189 |
| Avoid using if...else statements without curly braces | 193 |
| Avoid using if...else statements without curly braces | 195 |
| Violation | Line |
|---|---|
| Caught exception is rethrown, original stack trace may be lost | 71 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 66 |
| Overriding method merely calls super | 73 - 75 |
| Violation | Line |
|---|---|
| Caught exception is rethrown, original stack trace may be lost | 70 |
| Avoid using if statements without curly braces | 72 - 73 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 56 |
| Overriding method merely calls super | 59 - 61 |
| Overriding method merely calls super | 82 - 84 |
| Violation | Line |
|---|---|
| The field name indicates a constant but its modifiers do not | 82 |
| The field name indicates a constant but its modifiers do not | 87 |
| The field name indicates a constant but its modifiers do not | 92 |
| The field name indicates a constant but its modifiers do not | 103 |
| The field name indicates a constant but its modifiers do not | 108 |
| The field name indicates a constant but its modifiers do not | 113 |
| The String literal "Error while closing Statement." appears 4 times in this file; the first occurrence is on line 190 | 190 |
| The method save() has an NCSS line count of 59 | 216 - 294 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 340 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 54 - 55 |
| Avoid using if statements without curly braces | 57 - 58 |
| Avoid throwing raw exception types. | 86 |
| Avoid throwing raw exception types. | 91 |
| Avoid throwing raw exception types. | 94 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 56 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 73 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 69 |
| Caught exception is rethrown, original stack trace may be lost | 84 |
| Avoid using if...else statements without curly braces | 99 |
| Avoid using if...else statements without curly braces | 101 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 85 |
| Avoid using if statements without curly braces | 144 - 145 |
| Avoid using if statements without curly braces | 147 - 155 |
| These nested if statements could be combined | 158 - 160 |
| Avoid using if statements without curly braces | 163 - 164 |
| Avoid using if statements without curly braces | 171 - 172 |
| Overriding method merely calls super | 186 - 188 |
| Avoid using if statements without curly braces | 202 - 203 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 203 |
| Avoid using if...else statements without curly braces | 207 |
| Avoid using if...else statements without curly braces | 209 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 82 - 83 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'children'. | 150 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 94 - 95 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 52 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 48 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 38 |
| Avoid modifiers which are implied by the context | 46 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 46 |
| Avoid modifiers which are implied by the context | 52 |
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 64 |
| Avoid modifiers which are implied by the context | 70 |
| Avoid modifiers which are implied by the context | 76 |
| Avoid modifiers which are implied by the context | 82 |
| Avoid modifiers which are implied by the context | 90 |
| Avoid modifiers which are implied by the context | 97 |
| Avoid modifiers which are implied by the context | 104 |
| Avoid modifiers which are implied by the context | 111 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 62 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 86 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 87 |
| Avoid using if...else statements without curly braces | 141 |
| Avoid using if statements without curly braces | 142 - 143 |
| Caught exception is rethrown, original stack trace may be lost | 152 |
| Avoid using if...else statements without curly braces | 158 |
| Avoid using if statements without curly braces | 159 - 160 |
| Avoid using if...else statements without curly braces | 169 |
| Violation | Line |
|---|---|
| Perhaps 'artcilesFetched' could be replaced by a local variable. | 72 |
| Avoid throwing raw exception types. | 190 |
| Avoid using if...else statements without curly braces | 199 |
| Avoid using if...else statements without curly braces | 201 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 58 |
| Avoid modifiers which are implied by the context | 67 |
| Avoid modifiers which are implied by the context | 74 |
| Avoid modifiers which are implied by the context | 80 |
| Avoid modifiers which are implied by the context | 86 |
| Avoid modifiers which are implied by the context | 92 |
| Violation | Line |
|---|---|
| System.out.print is used | 60 |
| System.out.print is used | 70 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 55 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Avoid modifiers which are implied by the context | 54 |
| Avoid modifiers which are implied by the context | 56 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 58 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'ArrayList'; use the interface instead | 56 |
| Overridable method 'release' called during object construction | 63 |
| Overriding method merely calls super | 115 - 117 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 119 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'ArrayList'; use the interface instead | 56 |
| Overridable method 'release' called during object construction | 62 |
| Overriding method merely calls super | 114 - 116 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 118 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 84 |
| Avoid printStackTrace(); use a logger call instead. | 190 |
| Avoid printStackTrace(); use a logger call instead. | 192 |
| Avoid printStackTrace(); use a logger call instead. | 194 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'ArrayList'; use the interface instead | 54 |
| Overridable method 'release' called during object construction | 60 |
| Overriding method merely calls super | 112 - 114 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 116 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 40 |
| Avoid modifiers which are implied by the context | 41 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'ArrayList'; use the interface instead | 62 |
| Avoid using implementation types like 'HashMap'; use the interface instead | 73 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 143 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 147 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 50 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 53 |
| The field name indicates a constant but its modifiers do not | 60 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 50 |
| The user-supplied array 'types' is stored directly. | 94 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 93 |
| Avoid using if statements without curly braces | 137 - 138 |
| Avoid printStackTrace(); use a logger call instead. | 173 |
| Avoid printStackTrace(); use a logger call instead. | 175 |
| Avoid printStackTrace(); use a logger call instead. | 177 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 43 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 112 - 113 |
| Avoid using if...else statements without curly braces | 116 |
| Violation | Line |
|---|---|
| Perhaps 'rssUrl' could be replaced by a local variable. | 59 |
| Overridable method 'registerNode' called during object construction | 71 |
| System.out.print is used | 85 |
| System.out.print is used | 116 |
| No need to call String.valueOf to append to a string. | 128 |
| Overridable method 'registerNode' called during object construction | 132 |
| Avoid using if statements without curly braces | 181 - 182 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 78 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 94 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 95 |
| Avoid instantiating Integer objects. Call Integer.valueOf() instead. | 96 |
| Avoid using if statements without curly braces | 147 - 148 |
| Violation | Line |
|---|---|
| A method/constructor shouldn't explicitly throw java.lang.Exception | 57 |
| The String literal "Title " appears 6 times in this file; the first occurrence is on line 98 | 98 |
| The String literal "blblablabla " appears 14 times in this file; the first occurrence is on line 98 | 98 |
| The String literal "news " appears 15 times in this file; the first occurrence is on line 98 | 98 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 140 |
| Avoid using if statements without curly braces | 217 - 218 |
| Avoid using if statements without curly braces | 242 - 243 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 67 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 68 |
| Violation | Line |
|---|---|
| The String literal "100%" appears 4 times in this file; the first occurrence is on line 55 | 55 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 57 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 58 |
| Overridable method 'release' called during object construction | 68 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 149 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 153 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 185 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 189 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 140 - 141 |
| Avoid using if statements without curly braces | 147 - 148 |
| Avoid using if statements without curly braces | 154 - 155 |
| Avoid using if statements without curly braces | 161 - 162 |
| Avoid using if...else statements without curly braces | 171 |
| Avoid using if...else statements without curly braces | 173 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 55 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 49 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 296 - 297 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 105 |
| Avoid using if statements without curly braces | 172 - 173 |
| Avoid using if statements without curly braces | 178 - 179 |
| Violation | Line |
|---|---|
| Avoid using implementation types like 'ArrayList'; use the interface instead | 55 |
| Avoid using implementation types like 'ArrayList'; use the interface instead | 56 |
| Overridable method 'release' called during object construction | 64 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 62 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 58 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 57 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 65 |
| Violation | Line |
|---|---|
| Avoid printStackTrace(); use a logger call instead. | 108 |
| Avoid printStackTrace(); use a logger call instead. | 110 |
| Consider simply returning the value vs storing it in local variable 'toJSONString' | 220 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 95 |
| Avoid using if statements without curly braces | 129 - 130 |
| These nested if statements could be combined | 136 - 139 |
| Avoid using if statements without curly braces | 169 - 170 |
| Overriding method merely calls super | 290 - 292 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 95 |
| String.indexOf(char) is faster than String.indexOf(String). | 278 |
| String.indexOf(char) is faster than String.indexOf(String). | 278 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 99 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 74 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 55 |
| Avoid modifiers which are implied by the context | 61 |
| Violation | Line |
|---|---|
| Overridable method 'registerRecursivNode' called during object construction | 81 |
| Avoid using if statements without curly braces | 91 - 92 |
| Avoid using if statements without curly braces | 116 - 117 |
| Avoid throwing null pointer exceptions. | 117 |
| Avoid using if statements without curly braces | 122 - 123 |
| Avoid using if statements without curly braces | 143 - 144 |
| Avoid using if statements without curly braces | 146 - 147 |
| Avoid using if statements without curly braces | 167 - 168 |
| Avoid using if statements without curly braces | 171 - 172 |
| Avoid using if statements without curly braces | 174 - 175 |
| Violation | Line |
|---|---|
| Avoid modifiers which are implied by the context | 54 |
| Violation | Line |
|---|---|
| Overridable method 'addChildren' called during object construction | 143 |
| Avoid using if statements without curly braces | 255 - 256 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 99 - 100 |
| Avoid using if statements without curly braces | 101 - 102 |
| Avoid using if statements without curly braces | 124 - 125 |
| Avoid using if statements without curly braces | 163 - 164 |
| Avoid using if statements without curly braces | 168 - 169 |
| The String literal "nodeId" appears 8 times in this file; the first occurrence is on line 217 | 217 |
| Avoid using if statements without curly braces | 238 - 239 |
| The String literal "position" appears 4 times in this file; the first occurrence is on line 238 | 238 |
| Avoid using if statements without curly braces | 264 - 265 |
| Avoid using if statements without curly braces | 391 - 392 |
| Avoid using if statements without curly braces | 395 - 396 |
| Avoid using if...else statements without curly braces | 426 |
| Avoid using if...else statements without curly braces | 428 |
| Avoid using if...else statements without curly braces | 446 |
| Avoid using if...else statements without curly braces | 448 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 81 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 102 |
| Avoid using if statements without curly braces | 178 - 179 |
| Avoid using if statements without curly braces | 184 - 185 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 109 - 110 |
| The String literal "url" appears 4 times in this file; the first occurrence is on line 109 | 109 |
| Avoid using if statements without curly braces | 132 - 139 |
| Avoid printStackTrace(); use a logger call instead. | 137 |
| Avoid printStackTrace(); use a logger call instead. | 143 |
| Avoid using if statements without curly braces | 209 - 213 |
| Violation | Line |
|---|---|
| Overridable method 'release' called during object construction | 67 |
| Violation | Line |
|---|---|
| Perhaps 'model' could be replaced by a local variable. | 78 |
| Overridable method 'release' called during object construction | 85 |
| Avoid using if...else statements without curly braces | 108 |
| Avoid using if statements without curly braces | 110 - 111 |
| Avoid using if...else statements without curly braces | 119 |
| Avoid printStackTrace(); use a logger call instead. | 134 |
| Avoid printStackTrace(); use a logger call instead. | 137 |
| Avoid printStackTrace(); use a logger call instead. | 141 |
| Avoid using if...else statements without curly braces | 149 |
| Avoid using if...else statements without curly braces | 151 |
| Violation | Line |
|---|---|
| Avoid using if statements without curly braces | 106 - 107 |
| Avoid throwing null pointer exceptions. | 107 |
| Avoid using for statements without curly braces | 114 - 115 |
| Caught exception is rethrown, original stack trace may be lost | 157 |
| Caught exception is rethrown, original stack trace may be lost | 166 |
| Caught exception is rethrown, original stack trace may be lost | 175 |
| Caught exception is rethrown, original stack trace may be lost | 181 |
| Violation | Line |
|---|---|
| String.indexOf(char) is faster than String.indexOf(String). | 20 |
| Avoid using if statements without curly braces | 22 - 23 |
| Violation | Line |
|---|---|
| Consider simply returning the value vs storing it in local variable 'factory' | 101 |
| A catch statement should never catch throwable since it includes errors. | 102 |
| Violation | Line |
|---|---|
| The String literal "Cookie" appears 4 times in this file; the first occurrence is on line 61 | 61 |
| Avoid using if...else statements without curly braces | 113 |
| Avoid using while statements without curly braces | 119 - 120 |
| Avoid using if statements without curly braces | 150 - 151 |
| The String literal "Referer" appears 4 times in this file; the first occurrence is on line 151 | 151 |
| Avoid using if statements without curly braces | 157 - 158 |
| String.indexOf(char) is faster than String.indexOf(String). | 159 |
| Avoid using if...else statements without curly braces | 160 |
| Avoid using if...else statements without curly braces | 162 |
| Avoid using if statements without curly braces | 187 - 188 |
| Avoid using if statements without curly braces | 197 - 198 |
| Avoid using if statements without curly braces | 204 - 205 |
| Avoid using if statements without curly braces | 214 - 215 |
| Violation | Line |
|---|---|
| Avoid throwing null pointer exceptions. | 87 |
| Avoid throwing null pointer exceptions. | 93 |
| Violation | Line |
|---|---|
| The field name indicates a constant but its modifiers do not | 63 |